Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9657#discussion_r51227540
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ResolvedDataSource.scala
 ---
    @@ -235,11 +236,18 @@ object ResolvedDataSource extends Logging {
             // For partitioned relation r, r.schema's column ordering can be 
different from the column
             // ordering of data.logicalPlan (partition columns are all moved 
after data column).  This
             // will be adjusted within InsertIntoHadoopFsRelation.
    +
    +        val codec = options.get("compression.codec").flatMap(e =>
    +          Some(new 
CompressionCodecFactory(sqlContext.sparkContext.hadoopConfiguration)
    +            .getCodecClassByName(e).asInstanceOf[Class[CompressionCodec]])
    --- End diff --
    
    Since user can only set compression through 
DataFrameWriter.compress(codec), it is very unlikely to set a unknown codec 
name. Even user set a unknown codec, I think it is fine to just throw exception 
on driver side. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to