Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-176607410
A few comments:
1. As discussed offline, let's be consistent and always quote in sql query
generation, and never allow backticks in aliases.
2. Rename safeSQLIdent -> quoteIdentifier
3. Please add a unit test case for each expression that requires
safeSQLIdent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
