Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10964#discussion_r51239924
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -1463,4 +1463,11 @@ class SQLQuerySuite extends QueryTest with
SQLTestUtils with TestHiveSingleton {
|FROM (SELECT '{"f1": "value1", "f2": 12}' json, 'hello' as str)
test
""".stripMargin), Row("value1", "12", BigDecimal("3.14"), "hello"))
}
+
+ test("SPARK-13056: Null in map value causes NPE") {
+ val df = Seq(1 -> Map("abc" -> "somestring", "cba" ->
null)).toDF("key", "value")
+ df.registerTempTable("maptest")
--- End diff --
do we need to put the test in hive module? I think `DataFrameSuite` in sql
core module is a good place to put this test, we can just test
`df.select($"value"("abc"))` instead of registering a temp table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
