Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51355575
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,96 @@ class Analyzer(
*/
object ResolveSortReferences extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
- case s @ Sort(ordering, global, p @ Project(projectList, child))
- if !s.resolved && p.resolved =>
- val (newOrdering, missing) = resolveAndFindMissing(ordering, p,
child)
+ // Here, this rule only resolves the missing sort references if the
child is not Aggregate
+ // Another rule ResolveAggregateFunctions will resolve that case.
--- End diff --
The purpose of that rule is to resolve the aggregate functions (resolving
expressions for Sort is kind of side effects), it's better have that in the
`ResolveAggregateFunctions`. This also help to reduce the changes in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
