Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10959#discussion_r51385540
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/MasterSource.scala ---
    @@ -42,6 +42,6 @@ private[spark] class MasterSource(val master: Master) 
extends Source {
     
       // Gauge for waiting application numbers in cluster
       metricRegistry.register(MetricRegistry.name("waitingApps"), new 
Gauge[Int] {
    -    override def getValue: Int = master.waitingApps.size
    +    override def getValue: Int = master.apps.filter(_.state == 
ApplicationState.WAITING).size
    --- End diff --
    
    Digging a bit about current usage of `waitingApps`, I think it cannot be 
well reflect the actual meaning of waiting applications, even RUNNING 
applications are still in the `waitingApps` list. So I think your fix is simple 
and effective.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to