Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r51400507
--- Diff: python/pyspark/ml/regression.py ---
@@ -447,7 +447,7 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTreeModel(JavaModel):
+class DecisionTreeModel(JavaModel, MLWritable, MLReadable):
"""Abstraction for Decision Tree models.
--- End diff --
@Wenpei Please check wether it supports ```save/load``` for the peer Scala
implementation. Some algorithms such as ```DecisionTree``` did not support it
currently. And you should add doc test that will test the correctness of your
modification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
