Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6935#issuecomment-178142661
hi @steveloughran sorry for another really long delay on my end. mostly
this looks fine, there are some style nits and a couple of comments that need
updating. I also looked into the query param thing -- I played with it a bit
more and realized its kind of nuisance to test, but I did write a test on
`ApplicationCache` for it which I'll send to you.
I just had one more concern with the last read-through -- what happens when
an app goes from incomplete to complete? I did some manual testing, and things
seem to work. But, I have a fear that there is some lingering state that isn't
getting cleaned up. I will try to walk through things more carefully but maybe
you understand it well enough that you can reassure me (or perhaps you should
take another look yourself as well ...)
and of course, there are now merge conflicts which need to be fixed, sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
