Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10326#issuecomment-178254115
@SleepyThread thanks for cleaning up the code and adding tests. I think the
patch in its current state is only half way there, however. There's more
opportunity to abstract the duplicate code. Also there are still a lot of style
violations, and it no longer merges into master. Once you address my and
@dragos' comments then we'll take a closer look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
