Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11009#discussion_r51509057
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1257,7 +1257,8 @@ class DataFrame private[sql](
def drop(colNames: String*): DataFrame = {
val resolver = sqlContext.analyzer.resolver
val remainingCols =
- schema.filter(f => colNames.forall(n => !resolver(f.name, n))).map(f
=> Column(f.name))
+ schema.filter(f => colNames.forall(n => !resolver(f.name, n)))
--- End diff --
super nit: i would consider breaking before the filter also if you have to
break for the map. otherwise the filter looks special when really you are just
chaining a bunch of operations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
