Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10960#discussion_r51533812
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/WindowQuerySuite.scala
 ---
    @@ -133,44 +133,44 @@ class WindowQuerySuite extends QueryTest with 
SQLTestUtils with TestHiveSingleto
             Row("Manufacturer#1", "almond antique burnished rose metallic", 2, 
258.10677784349247, 258.10677784349247, 34, 66619.10876874997, 
0.811328754177887, 2801.7074999999995),
             Row("Manufacturer#1", "almond antique burnished rose metallic", 2, 
273.70217881648085, 273.70217881648085, 2, 74912.88268888886, 1.0, 
4128.782222222221),
             Row("Manufacturer#1", "almond antique burnished rose metallic", 2, 
273.70217881648085, 273.70217881648085, 34, 74912.88268888886, 1.0, 
4128.782222222221),
    -        Row("Manufacturer#1", "almond antique chartreuse lavender yellow", 
34, 230.9015158547037, 230.9015158547037, 2, 53315.510023999974, 
0.6956393773976641, 2210.7864),
    --- End diff --
    
    It would be nice to see we can tolerate some small numerical differences in 
query tests. But this is out of scope here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to