Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11019#discussion_r51534316
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -36,11 +36,11 @@ import org.apache.spark.util.Utils
/**
* Java source for evaluating an [[Expression]] given a [[InternalRow]] of
input.
*
- * @param code The sequence of statements required to evaluate the
expression.
- * @param isNull A term that holds a boolean value representing whether
the expression evaluated
- * to null.
- * @param value A term for a (possibly primitive) value of the result of
the evaluation. Not
- * valid if `isNull` is set to `true`.
+ * @param code The Java source code required to evaluate the expression.
+ * @param isNull Name of the variable that holds the boolean value
representing whether the
+ * expression evaluated to null.
+ * @param value Name of the variable that holds the (possibly primitive)
value of the result
--- End diff --
note that `value` could be a constant too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
