Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10960#discussion_r51535734
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
 ---
    @@ -436,3 +436,21 @@ case class Murmur3Hash(children: Seq[Expression], 
seed: Int) extends Expression
         }
       }
     }
    +
    +/**
    +  * An expression that will print the value of child to stderr (used for 
debugging codegen).
    +  */
    +case class Echo(child: Expression) extends UnaryExpression {
    --- End diff --
    
    So this is only used if you construct the expressions manually?
    
    I'd rename this to PrintToStderr. Echo means it is returning whatever you 
are typing in, which is not what this is about.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to