Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10844#discussion_r51549912
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
 ---
    @@ -180,6 +218,29 @@ case class Join(
         }
       }
     
    +  override protected def validConstraints: Set[Expression] = {
    +    joinType match {
    +      case Inner if condition.isDefined =>
    +        left.constraints
    +          .union(right.constraints)
    +          .union(splitConjunctivePredicates(condition.get).toSet)
    +      case LeftSemi if condition.isDefined =>
    +        left.constraints
    +          .union(right.constraints)
    --- End diff --
    
    For left semi join, maybe it is not necessary to union the constrains from 
the right side since we will not output any columns from the right table?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to