Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11010#discussion_r51635675
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -426,14 +435,13 @@ public Location lookup(Object keyBase, long
keyOffset, int keyLength) {
*
* This is a thread-safe version of `lookup`, could be used by multiple
threads.
*/
- public void safeLookup(Object keyBase, long keyOffset, int keyLength,
Location loc) {
+ public void safeLookup(Object keyBase, long keyOffset, int keyLength,
Location loc, int hash) {
assert(longArray != null);
if (enablePerfMetrics) {
numKeyLookups++;
}
- final int hashcode = HASHER.hashUnsafeWords(keyBase, keyOffset,
keyLength);
- int pos = hashcode & mask;
+ int pos = hash & mask;
--- End diff --
This doesn't work if hash is negative right? Not clear to me the new hash
doesn't return negatives. assert this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
