Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/11030#discussion_r51642270
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/ContinuousQueryManagerSuite.scala
---
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.streaming
+
+import scala.concurrent.Future
+import scala.util.Random
+import scala.util.control.NonFatal
+
+import org.scalatest.BeforeAndAfter
+import org.scalatest.concurrent.Eventually._
+import org.scalatest.concurrent.PatienceConfiguration.Timeout
+import org.scalatest.time.Span
+import org.scalatest.time.SpanSugar._
+
+import org.apache.spark.sql.execution.streaming.{MemorySink, MemoryStream,
StreamExecution}
+import org.apache.spark.sql.test.SharedSQLContext
+import org.apache.spark.sql.{Dataset, ContinuousQuery, StreamTest}
+
+class ContinuousQueryManagerSuite extends StreamTest with SharedSQLContext
with BeforeAndAfter {
+
+ import AwaitTerminationTester._
+ import testImplicits._
+
+ after {
+ assert(sqlContext.streams.active.isEmpty)
+ }
+
+ test("listing") {
+ val (m1, ds1) = makeDataset
+ val (m2, ds2) = makeDataset
+ val (m3, ds3) = makeDataset
+
+ withQueriesOn(ds1, ds2, ds3) { queries =>
+ require(queries.size === 3)
+ assert(sqlContext.streams.active.toSet === queries.toSet)
+ val (q1, q2, q3) = (queries(0), queries(1), queries(2))
+
+ assert(sqlContext.streams.get(q1.name).eq(q1))
+ assert(sqlContext.streams.get(q2.name).eq(q2))
+ assert(sqlContext.streams.get(q3.name).eq(q3))
+
+ q1.stop()
+
+ assert(sqlContext.streams.active.toSet === Set(q2, q3))
+ val ex1 = withClue("no error while getting non-active query") {
+ intercept[IllegalArgumentException] {
+ sqlContext.streams.get(q1.name).eq(q1)
+ }
+ }
+ assert(ex1.getMessage.contains(q1.name), "error does not contain
name of query to be fetched")
+ assert(sqlContext.streams.get(q2.name).eq(q2))
+
+ m2.addData(0) // q2 should terminate with error
+
+ eventually(Timeout(streamingTimout)) {
+ require(!q2.isActive)
+ require(q2.exception.isDefined)
+ }
+ val ex2 = withClue("no error while getting non-active query") {
+ intercept[IllegalArgumentException] {
+ sqlContext.streams.get(q2.name).eq(q2)
+ }
+ }
+
+ assert(sqlContext.streams.active.toSet === Set(q3))
+ }
+ }
+
+ test("awaitAnyTermination") {
--- End diff --
These tests are likely to be flaky because of the timing related issues.
Other then making the timings more coarse, i am not sure how else to test
awaitTerminations's behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
