Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10677#issuecomment-178869267
@davies the PR is in good shape. The two main (minor) issues I could find
are:
- The use of the Hive gid which is wrong. We could also break some
compatibility and solve it at the root.
- The usefulllnes of child expressions in the ```grouping_id``` function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
