Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10989#discussion_r51683070
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
@@ -389,14 +379,16 @@ case class TungstenAggregate(
UnsafeRow $keyTerm = (UnsafeRow) $iterTerm.getKey();
UnsafeRow $bufferTerm = (UnsafeRow) $iterTerm.getValue();
$outputCode
+
+ if (shouldStop()) return;
--- End diff --
Once `shouldStop()` returns true, the caller should exit the loop (via
return).
`map.free()` is called only when it had consumed all the items in the loop
(without return).
Will added these to the doc string of shouldStop().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
