Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/10953#issuecomment-179511363
I have a more fundamental question - given that this patch does not add a
whole lot of new functionality but just ports the currently functionality to
use the new Kafka API, is there a reason we can't refactor the current
`KafkaRDD` and `*KafkaDStream` classes such that the functionality accessing
the Kafka API is wrapped in methods(say `fetchFromKafka` or something), but
everything else (rate limiting, checkpointing, producing new RDDs) etc is
"outside". That way the new API-use can be simply in overridden methods
(`override def fetchFromKafka`).
Also, can we change the package name and module names to something other
than `newapi` - I mean `new` is relative - Kafka could end up having a newer
API at some point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
