Github user CodingCat commented on the pull request:

    https://github.com/apache/spark/pull/8610#issuecomment-179563852
  
    @andrewor14 thanks for reviewing this, I'm currently in traveling, I will 
move https://github.com/apache/spark/pull/4123 and the check here to 
SparkSubmit later 
    
    I think we only need to check whether CoresPerExecutor is no less than 
CoresPerTask `only when the user has an explicit configuration on 
coresPerExecutor`
    
    The reason is that when the user does not explicitly specify 
coresPerExecutor (default is 1), there are still `many chances that executors 
has more cores than coresPerTask`...if we simply throw exceptions to the user 
in this case, the user has to set an explicit value of coresPerExecutor 
`whenever they set a value on coresPerTask` which is not an ideal situtation in 
terms of user-friendly , your thoughts?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to