Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11008#discussion_r51834737
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Sort.scala
---
@@ -93,4 +98,63 @@ case class Sort(
sortedIterator
}
}
+
+ override def upstream(): RDD[InternalRow] = {
+ child.asInstanceOf[CodegenSupport].upstream()
+ }
+
+ // Name of sorter variable used in codegen.
+ private var sorterVariable: String = _
--- End diff --
it's ok here as discussed offline. i just found mutable state in here as a
way to pass variable names through pretty brittle. maybe good to have a more
general abstraction for this in codegen, but not that big of a deal right now/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
