Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11034#discussion_r51953075
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
 ---
    @@ -0,0 +1,141 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming
    +
    +import java.io.{BufferedWriter, OutputStreamWriter}
    +
    +import scala.collection.mutable.ArrayBuffer
    +
    +import org.apache.hadoop.fs.{FileStatus, FileSystem, Path}
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.sql.{DataFrame, SQLContext}
    +import org.apache.spark.sql.types.{StringType, StructType}
    +import org.apache.spark.util.collection.OpenHashSet
    +
    +/**
    + * A very simple source that reads text files from the given directory as 
they appear.
    + */
    +class FileStreamSource(
    +    sqlContext: SQLContext,
    +    metadataPath: String,
    +    path: String,
    +    dataSchema: Option[StructType],
    +    dataFrameBuilder: Array[String] => DataFrame) extends Source with 
Logging {
    +
    +  import sqlContext.implicits._
    +
    +  /** Returns the schema of the data from this source */
    +  override def schema: StructType = dataSchema.getOrElse(new 
StructType().add("value", StringType))
    --- End diff --
    
    Updated the logic here. Now if there are any existing files, it will use 
them to infer the schema. And also added a test for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to