Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1269#issuecomment-49655673
@akopich Thanks for working on PLSA! This is a big feature and it
introduces many public traits/classes. Could you please summarize the public
methods? Some of them may be unnecessary to expose to end users and we should
hide them. The other issue is about the code style. Please follow the guide at
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide and
update the PR, for example:
1. remove "created by ..." comments generated by intellij
2. organize imports into groups: java, scala, 3rd party, and spark
3. doc for every trait/class. Some only contain doc for parameters but miss
the summary.
4. indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
