Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11095#discussion_r52216780
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorterSuite.java
---
@@ -75,6 +75,9 @@ public void testBasicSorting() throws Exception {
// Write the records into the data page and store pointers into the
sorter
long position = dataPage.getBaseOffset();
for (String str : dataToSort) {
+ if (!sorter.hasSpaceForAnotherRecord()) {
+
sorter.expandPointerArray(consumer.allocateArray(sorter.numRecords() * 2 * 2));
--- End diff --
I think this should only be `* 2` because the shuffle sorter only uses one
array entry per record instead of the pair of entires which is used by the more
general prefix sorter. I can fix this up myself on merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
