Github user markpavey commented on the pull request:

    https://github.com/apache/spark/pull/11135#issuecomment-182326218
  
    Is it possible to retest without submitting more changes? I haven't got any 
more to add.
    
    A quick search of the spark-core code base shows that URIs are mostly 
created with File.toURI(), hence I went for that in my patch.
    
    There are a couple of different approaches:
     - org.apache.spark.util.Utils.resolveURI(path) catches the 
URISyntaxException
     - SparkContext.addJar(path) looks for a backslash character to tell if 
it's a Windows path
     - org.apache.spark.deploy.ClientArguments.isValidJarUrl(s) treats paths as 
invalid if they fail URI parsing
    
    An exhaustive search might reveal more.
    
    It is only the problem with viewing the logs in the web UI that has been 
causing us pain, hence that was what we fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to