Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10993#discussion_r52503364
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -73,17 +73,13 @@ private[spark] class CoarseMesosSchedulerBackend(
       private val shuffleServiceEnabled = 
conf.getBoolean("spark.shuffle.service.enabled", false)
     
       // Cores we have acquired with each Mesos task ID
    -  val coresByTaskId = new HashMap[Int, Int]
    +  val coresByTaskId = new HashMap[String, Int]
       var totalCoresAcquired = 0
     
    -  val slaveIdsWithExecutors = new HashSet[String]
    -
    -  // Maping from slave Id to hostname
    -  private val slaveIdToHost = new HashMap[String, String]
    -
    -  val taskIdToSlaveId: HashBiMap[Int, String] = HashBiMap.create[Int, 
String]
    -  // How many times tasks on each slave failed
    -  val failuresBySlaveId: HashMap[String, Int] = new HashMap[String, Int]
    +  // SlaveID -> Slave
    +  // This map accumulates entries for the duration of the job.  Slaves are 
never deleted, because
    +  // we need to maintain e.g. failure state and connection state.
    +  private val slaves = new HashMap[String, Slave]
    --- End diff --
    
    elsewhere in Spark we would call this class `SlaveInfo` instead of just 
`Slave`, so we don't confuse it with the Mesos Slave


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to