Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52518306
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class ShuffleBlockFetcherIterator(
logDebug("Sending request for %d blocks (%s) from %s".format(
req.blocks.size, Utils.bytesToString(req.size),
req.address.hostPort))
bytesInFlight += req.size
+ reqsInFlight += 1
// so we can look up the size of each blockID
val sizeMap = req.blocks.map { case (blockId, size) =>
(blockId.toString, size) }.toMap
+ val remainingBlocks = new ArrayBuffer[String]() ++ sizeMap.keys
--- End diff --
@zsxwing Just curious both ArrayBuffer and HashSet seem to be thread safe I
presume from looking at the scala API and blockId seems to be unique. Just
curious why we need to change it else I don't mind changing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
