Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11051#discussion_r52526783
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1291,4 +1291,16 @@ class DataFrameSuite extends QueryTest with
SharedSQLContext {
Seq(1 -> "a").toDF("i", "j").filter($"i".cast(StringType) === "1"),
Row(1, "a"))
}
+
+ test("SPARK-12982: Add table name validation in temp table
registration") {
+ val df = Seq("foo", "bar").map(Tuple1.apply).toDF("col")
+ // invalid table name test as below
+ intercept[AnalysisException](df.registerTempTable("t~"))
+ // valid table name test as below
+ df.registerTempTable("table1")
+ // another invalid table name test as below
+ intercept[AnalysisException](df.registerTempTable("#$@sum"))
+ // another invalid table name test as below
+ intercept[AnalysisException](df.registerTempTable("table!#"))
--- End diff --
It is a bug, but it was in code base already. The fix is trivial (I need to
add a separate rule for parsing table identifiers - which checks for an EOF).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
