GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/11159
[SPARK-13276] Catch bad characters at the end of a Table
Identifier/Expression string
The parser currently parses the following strings without a hitch:
* Table Identifier:
* `a.b.c` should fail, but results in the following table identifier `a.b`
* `table!#` should fail, but results in the following table identifier
`table`
* Expression
* `1+2 r+e` should fail, but results in the following expression `1 + 2`
This PR fixes this by adding terminated rules for both expression parsing
and table identifier parsing.
cc @cloud-fan (we discussed this in
https://github.com/apache/spark/pull/10649) @jayadevanmurali (this causes your
PR https://github.com/apache/spark/pull/11051 to fail)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hvanhovell/spark SPARK-13276
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11159
----
commit 9f88511bf96a5785d6c1ca00fb1c73950a3b43bb
Author: Herman van Hovell <[email protected]>
Date: 2016-02-10T21:34:00Z
Improve rules to catch bad characters at the end of a Table
Identifier/Expression string.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
