Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11141#discussion_r52548005
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
    @@ -101,10 +102,12 @@ private[sql] case class PhysicalRDD(
         override val metadata: Map[String, String] = Map.empty,
         isUnsafeRow: Boolean = false,
         override val outputPartitioning: Partitioning = UnknownPartitioning(0))
    -  extends LeafNode {
    +  extends LeafNode with CodegenSupport {
     
       protected override def doExecute(): RDD[InternalRow] = {
    -    if (isUnsafeRow) {
    +    val conf = SQLContext.getActive().get
    +    // The vectorized reader does not produce UnsafeRows. In this case we 
will convert.
    +    if (isUnsafeRow && 
!conf.getConf(SQLConf.PARQUET_VECTORIZED_READER_ENABLED)) {
    --- End diff --
    
    We should also check that the data source is Parquet or not. I'd suggest to 
do this in `createFromDataSource`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to