Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11083#discussion_r52566924
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -76,6 +77,12 @@ case class OrderedDistribution(ordering: Seq[SortOrder])
extends Distribution {
}
/**
+ * Represents data where tuples are broadcasted to every node. It is
quite common that the
+ * entire set of tuples is transformed into different data structure.
+ */
+case class BroadcastDistribution(f: Iterable[InternalRow] => Any =
identity) extends Distribution
--- End diff --
i'm thinking maybe it's better to just declare that we want a hashed
broadcast distribution, and then don't take a closure. The reason it is bad to
take a closure is that this won't work if we want to whole-stage codegen the
building of the hash table, or if we want to change the internal engine to a
push-based model.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
