GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/11171

    [SPARK-13282][SQL] LogicalPlan toSql should just return a String

    Rather than Option[String].
    
    Previously we were using Option[String] and None to indicate the case when 
Spark fails to generate SQL. It is easier to just use exceptions to propagate 
error cases, rather than having for comprehension everywhere. I also introduced 
a "build" function that simplifies string concatenation (i.e. no need to reason 
about whether we have an extra space or not).


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-13282

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11171
    
----
commit 9fd34fc1fa27c09cfa5426a53be85cbc5e0460c3
Author: Reynold Xin <[email protected]>
Date:   2016-02-11T10:08:15Z

    [SPARK-13282][SQL] LogicalPlan toSql should just return a String rather 
than Option[String]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to