Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1510#discussion_r15214158
--- Diff:
tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala ---
@@ -99,9 +99,25 @@ object GenerateMIMAIgnore {
(ignoredClasses.flatMap(c => Seq(c, c.replace("$", "#"))).toSet,
ignoredMembers.toSet)
}
+ /** Scala reflection does not let us see inner function even if they are
upgraded
+ * to public for some reason. So had to resort to java reflection to
get all inner
+ * functions with $$ in there name.
+ */
+ def getInnerFunc(classSymbol: unv.ClassSymbol): Seq[String] = {
--- End diff --
Can this be called `getInnerFunctions` since it enumerates multiple inner
functions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
