Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11109#discussion_r52675400
--- Diff: dev/lint-python ---
@@ -96,6 +98,32 @@ fi
rm "$PEP8_REPORT_PATH"
+# Check that the documentation builds acceptably, skip check if sphinx is
not installed.
+if hash "$SPHINXBUILD" 2> /dev/null; then
+ cd python/docs
+ make clean
+ export SPHINXOPTS=""
+ make linkcheck &>> "$SPHINX_REPORT_PATH" || lint_status=1
--- End diff --
Should be `&>` instead of `&>>`. Otherwise I got the following error
message:
~~~
dev/lint-python: line 106: syntax error near unexpected token `>'
dev/lint-python: line 106: ` make linkcheck &>> "$SPHINX_REPORT_PATH" ||
lint_status=1'
~~~
Btw, do we really want to verify links? Links may die due to external
website changes. If a PR fails because of this, the author may not even know
how to fix them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
