Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8760#discussion_r52682469
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -21,6 +21,7 @@ import java.util.Collections
import java.util.concurrent._
import java.util.regex.Pattern
+import scala.collection.immutable.Set
--- End diff --
this is very subjective, but I find it really confusing to have fully
imported both immutable and mutable collections in the same file. (a) If you
really want the immutable one, I'd just fully qualify it where you need to
`collection.immutable.Set`. Or maybe (b) you could just use a mutable Set here
for consistency? Or (c) if the code here doesn't care whether its mutable or
immutable, you could take a `collection.Set`, and just fully qualify it where
you use it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
