Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/11167#discussion_r52691236
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -181,9 +186,7 @@ private[spark] class TaskSetManager(
private def addPendingTask(index: Int) {
// Utility method that adds `index` to a list only if it's not already
there
def addTo(list: ArrayBuffer[Int]) {
- if (!list.contains(index)) {
- list += index
- }
+ list += index
}
--- End diff --
You're in luck because I accidentally merged before Jenkins got to it, so
we reverted it pending tests. There's a new PR here:
https://github.com/apache/spark/pull/11175
Would you mind sticking this comment there? Agree with your sentiment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
