Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11148#discussion_r52715605
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -119,6 +120,18 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:
SQLContext) extends Loggi
limitSQL = limit.sql
} yield s"$childSQL LIMIT $limitSQL"
+ // TABLESAMPLE is part of tableSource clause in the parser,
+ // and thus we must handle it with subquery.
+ case Sample(lb, ub, withReplacement, _, child @ Subquery(alias,
grandChild))
--- End diff --
this seems pretty brittle. i wonder if we can change sample to make it very
clear this is either a table sample, or a normal sample.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
