Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10894#issuecomment-183421313 I spot one other place where we might be able to use this in `TakeOrderedAndProject.execute()`. There's also a usage in `TakeOrderedAndProjectNode`, but I'm not sure if we want to update that one. Also, one minor naming suggestion: I'd probably call this `LazilyGeneratedOrdering`, with a 'd', since it _is_ an ordering rather than a factory for making them. Aside from those two minor changes, this looks good to me. Sorry for missing those suggestions on the first review pass.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org