Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11190#discussion_r52810643
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystQlSuite.scala 
---
    @@ -201,4 +201,12 @@ class CatalystQlSuite extends PlanTest {
         parser.parsePlan("select sum(product + 1) over (partition by (product 
+ (1)) order by 2) " +
           "from windowData")
       }
    +
    +  test("subquery") {
    +    parser.parsePlan("select (select max(b) from s) ss from t")
    --- End diff --
    
    The only thing we are testing here is that things don't go really really 
wrong. I'd prefer it if we test the plan as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to