Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11193#discussion_r52821641
--- Diff:
network/common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -99,6 +122,9 @@ public long transferTo(final WritableByteChannel target,
final long position) th
protected void deallocate() {
--- End diff --
In order for this code to be correct / free from leaks, we need to ensure
that `deallocate()` is always eventually called once this message is
constructed. Instances of this class are constructed at a single call-site in
`MessageEncoder`. Once we construct the message, we immediately pass it to
Netty code, which I assume will free it at the proper time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
