Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11178#issuecomment-183613871
This patch ended up changing substantially, so I'd like @ScrapCodes to take
a quick look at it.
In a nutshell:
- I modified the `tools` project to remove a direct dependency on Spark, so
`sbt/sbt tools/fullClasspath` will now return the classpath for the
`GenerateMIMAIgnore` class itself plus its own dependencies.
- This required me to delete two classes full of dead code that we don't
use anymore
- `GenerateMIMAIgnore` now uses
[ClassUtil](http://software.clapper.org/classutil/) to find all of the Spark
classes rather than our homemade JAR traversal code. The problem in our own
code was that it didn't handle folders of classes properly, which is necessary
in order to generate excludes with an assembly-free Spark build.
- `./dev/mima` no longer runs through `spark-class`, eliminating the need
to reason about classpath ordering between `SPARK_CLASSPATH` and the assembly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
