Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11195#discussion_r52851386
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala 
---
    @@ -105,6 +105,27 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest 
with SQLTestUtils {
         checkHiveQl("SELECT id FROM t0 UNION ALL SELECT CAST(id AS INT) AS id 
FROM t0")
       }
     
    +  test("union distinct") {
    +    checkHiveQl("SELECT * FROM t0 UNION SELECT * FROM t0")
    +  }
    +
    +  // Parser is unable to parse the following query:
    +  // SELECT  `u_1`.`id`
    +  // FROM (((SELECT  `t0`.`id` FROM `default`.`t0`)
    +  // UNION ALL (SELECT  `t0`.`id` FROM `default`.`t0`))
    +  // UNION ALL (SELECT  `t0`.`id` FROM `default`.`t0`)) AS u_1
    +  ignore("three-child union") {
    --- End diff --
    
    Thank you! @hvanhovell 
    
    Based on the comment by @rxin , I think we still need a nesting version 
here for future extension, instead hacking the SQL generation. 
    
    Saw @viirya did a similar work last month: 
https://github.com/apache/spark/pull/10660. Maybe @viirya can do me a favor for 
completing this? Thank you! : )
    
    Also cc @liancheng 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to