Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6707#discussion_r52854187
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala
 ---
    @@ -174,6 +176,130 @@ class ReceivedBlockHandlerSuite
         }
       }
     
    +  test("Test Block - count messages") {
    +    // Test count with BlockManagedBasedBlockHandler
    +    testCountWithBlockManagerBasedBlockHandler(true)
    --- End diff --
    
    I think that this is a bad function name: if I'm only reading this line and 
am not jumping around in the IDE, how I am I supposed to know what this boolean 
parameter denotes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to