Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11209#discussion_r53042324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -167,7 +173,7 @@ case class HyperLogLogPlusPlus(
val v = child.eval(input)
if (v != null) {
// Create the hashed value 'x'.
- val x = MurmurHash.hash64(v)
+ val x = hasher.computeHash(v, childDataType)
--- End diff --
For the final version I want to create an xxHash companion object to the
expression which implements this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
