GitHub user joehalliwell opened a pull request:
https://github.com/apache/spark/pull/11221
[SPARK-13242] [SQL] Generate one method per `when` clause
This patch modifies code generation to split `when` clauses into separate
methods.
As the included test demonstrates, with the previous behaviour it was quite
easy to breach the 64KB method size limit with even moderately complex `when`
expressions.
This contribution is my original work and I license the work to the project
under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joehalliwell/spark SPARK-13242
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11221
----
commit 4dbdf6e15d1116b8e1eb44822fd29ead9b7d817d
Author: Joe Halliwell <[email protected]>
Date: 2016-02-09T15:36:15Z
Add test case
commit 2b594539de4539e7d05345595149f0eb942640e1
Author: Joe Halliwell <[email protected]>
Date: 2016-02-16T17:29:17Z
Split when clauses into separate methods
This is presumably slower than packing them all into a single method, but
does allow many more clauses. A further improvement might be to combine
the two approaches using some heuristic to determine how many clauses
can be combined in a single method.
commit 57c78a7a75935e182b8e3622a3e00e5c5dc7fd74
Author: Joe Halliwell <[email protected]>
Date: 2016-02-16T17:55:58Z
Smoketest generated code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
