GitHub user mengxr opened a pull request:

    https://github.com/apache/spark/pull/11226

    [SPARK-13355] [MLLIB] replace GraphImpl.fromExistingRDDs by Graph.apply

    `GraphImpl.fromExistingRDDs` expects preprocessed vertex RDD as input. We 
call it in LDA without validating this requirement. So it might introduce 
errors. Replacing it by `Graph.apply` would be safer and more proper because it 
is a public API. The tests still pass. So maybe it is safe to use 
`fromExistingRDDs` here (though it doesn't seem so based on the implementation) 
or the test cases are special. @jkbradley @ankurdave 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mengxr/spark SPARK-13355

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11226
    
----
commit 2df920f8bf712d294f97d5813dcd50486bbcc4bc
Author: Xiangrui Meng <[email protected]>
Date:   2016-02-16T19:11:14Z

    replace GraphImpl.fromExistingRDDs by Graph

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to