Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10757#discussion_r53118135
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
 ---
    @@ -130,12 +134,17 @@ case class GetStructField(child: Expression, ordinal: 
Int, name: Option[String]
           }
         })
       }
    +}
    +
    +case class PrettyGetStructField(child: Expression, name: String, dataType: 
DataType)
    +  extends UnaryExpression with Unevaluable {
     
    -  override def sql: String = child.sql + s".`${childSchema(ordinal).name}`"
    +  override def sql: String = s"${child.sql}.$name"
    --- End diff --
    
    can we use this string as the name of `PrettyAttribute`? Then we can avoid 
creating these classes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to