Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11231#discussion_r53120113
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Benchmark.scala ---
    @@ -93,7 +93,8 @@ private[spark] object Benchmark {
         if (SystemUtils.IS_OS_MAC_OSX) {
           Utils.executeAndGetOutput(Seq("/usr/sbin/sysctl", "-n", 
"machdep.cpu.brand_string"))
         } else if (SystemUtils.IS_OS_LINUX) {
    -      Utils.executeAndGetOutput(Seq("/usr/bin/grep", "-m", "1", "\"model 
name\"", "/proc/cpuinfo"))
    +      val grepPath = Utils.executeAndGetOutput(Seq("which", "grep"))
    +      Utils.executeAndGetOutput(Seq(grepPath, "-m", "1", "model name", 
"/proc/cpuinfo"))
    --- End diff --
    
    "\"model name\"" doesn't work on my linux. "model name" works. Don't know 
if it is special case or general.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to