Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/spark/pull/1506#discussion_r15251850
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -215,9 +215,15 @@ object SparkEnv extends Logging {
"MapOutputTracker",
new
MapOutputTrackerMasterActor(mapOutputTracker.asInstanceOf[MapOutputTrackerMaster],
conf))
- val blockManagerMaster = new BlockManagerMaster(registerOrLookup(
- "BlockManagerMaster",
- new BlockManagerMasterActor(isLocal, conf, listenerBus)), conf)
+ val blockManagerMasterType = conf.get("spark.blockmanager.type",
"standalone")
+ var blockManagerMaster: BlockManagerMaster = null
+ blockManagerMasterType match {
+ case _ =>
+ // Since currently only one option exists, this is what is to be
done in any case.
+ blockManagerMaster = new
StandaloneBlockManagerMaster(registerOrLookup(
--- End diff --
So if I want to use different BlockManagerMaster implementation I have to
modified this code to support different type?
It is preferable to use fully classified class name to allow pluggability
so as long as the Class implementation is in the classpath then it should be
able to use the different implementation of the BlockManagerMaster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
