Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9483#discussion_r53124507
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -211,7 +211,7 @@ abstract class RDD[T: ClassTag](
       // Our dependencies and partitions will be gotten by calling subclass's 
methods below, and will
       // be overwritten when we're checkpointed
       private var dependencies_ : Seq[Dependency[_]] = null
    -  @transient private var partitions_ : Array[Partition] = null
    +  @transient @volatile private var partitions_ : Array[Partition] = null
    --- End diff --
    
    per my understanding, I don't think we need the `@volatile` here, probably 
the only place we need to change is the add the modifier of `synchronized` for 
method `getPartitions` in the concrete sub class of RDD, which will force the 
cpu cache to memory as the barrier fence of jvm memory model.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to