Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11053#discussion_r53154866
  
    --- Diff: 
examples/src/main/java/org/apache/spark/examples/ml/JavaDocument.java ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.examples.ml;
    +
    +import java.io.Serializable;
    +
    +/**
    + * Unlabeled instance type, Spark SQL can infer schema from Java Beans.
    + */
    +public class JavaDocument implements Serializable {
    +
    +  /** Serializable version identifier */
    +  private static final long serialVersionUID = 7090547542135729169L;
    +  private long id;
    +  private String text;
    +
    +  public JavaDocument(long id, String text) {
    +    this.id = id;
    +    this.text = text;
    +  }
    +
    +  public long getId() {
    +    return this.id;
    +  }
    +
    +  public void setId(long id) {
    --- End diff --
    
    I don't think you need setters, but you probably need a no-arg constructor 
to make this JavaBeans-friendly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to